Sync TimeProvider and cleanup #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
approved these changes
Jun 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #1339 +/- ##
==========================================
+ Coverage 83.49% 83.54% +0.04%
==========================================
Files 270 270
Lines 6379 6374 -5
Branches 1003 1003
==========================================
- Hits 5326 5325 -1
+ Misses 844 840 -4
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Syncing our TimeProvider with the official one:
https://github.com/dotnet/runtime/blob/main/src/libraries/Common/src/System/TimeProvider.cs
Contributes to #1144
Confirm the following